Skip to content

Commit

Permalink
nested record iframe (#63)
Browse files Browse the repository at this point in the history
* pick nested branch

* iframe snapshot

* temp: add bundle file to git

* revert ignore file

* refactor iframe impl
1. do callback one iframe is loaded, let rrweb handle the rest
2. handle iframe as normal element in rebuild

* rename hook function
  • Loading branch information
Yuyz0112 authored Feb 7, 2021
1 parent a3ff5e5 commit 98aa732
Show file tree
Hide file tree
Showing 11 changed files with 343 additions and 7 deletions.
24 changes: 20 additions & 4 deletions src/rebuild.ts
Original file line number Diff line number Diff line change
Expand Up @@ -198,13 +198,20 @@ export function buildNodeWithSN(
map: idNodeMap;
skipChild?: boolean;
hackCss: boolean;
afterAppend?: (n: INode) => unknown;
},
): INode | null {
const { doc, map, skipChild = false, hackCss = true } = options;
const { doc, map, skipChild = false, hackCss = true, afterAppend } = options;
let node = buildNode(n, { doc, hackCss });
if (!node) {
return null;
}
if (n.rootId) {
console.assert(
((map[n.rootId] as unknown) as Document) === doc,
'Target document should has the same root id.',
);
}
// use target document as root document
if (n.type === NodeType.Document) {
// close before open to make sure document was closed
Expand All @@ -215,6 +222,7 @@ export function buildNodeWithSN(

(node as INode).__sn = n;
map[n.id] = node as INode;

if (
(n.type === NodeType.Document || n.type === NodeType.Element) &&
!skipChild
Expand All @@ -225,14 +233,20 @@ export function buildNodeWithSN(
map,
skipChild: false,
hackCss,
afterAppend,
});
if (!childNode) {
console.warn('Failed to rebuild', childN);
} else {
node.appendChild(childNode);
continue;
}

node.appendChild(childNode);
if (afterAppend) {
afterAppend(childNode);
}
}
}

return node as INode;
}

Expand Down Expand Up @@ -274,15 +288,17 @@ function rebuild(
doc: Document;
onVisit?: (node: INode) => unknown;
hackCss?: boolean;
afterAppend?: (n: INode) => unknown;
},
): [Node | null, idNodeMap] {
const { doc, onVisit, hackCss = true } = options;
const { doc, onVisit, hackCss = true, afterAppend } = options;
const idNodeMap: idNodeMap = {};
const node = buildNodeWithSN(n, {
doc,
map: idNodeMap,
skipChild: false,
hackCss,
afterAppend,
});
visit(idNodeMap, (visitedNode) => {
if (onVisit) {
Expand Down
93 changes: 93 additions & 0 deletions src/snapshot.ts
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,34 @@ export function _isBlockedElement(
return false;
}

// https://stackoverflow.com/a/36155560
function onceIframeLoaded(
iframeEl: HTMLIFrameElement,
listener: () => unknown,
) {
const win = iframeEl.contentWindow;
if (!win) {
return;
}
// document is loading
if (win.document.readyState !== 'complete') {
iframeEl.addEventListener('load', listener);
return;
}
// check blank frame for Chrome
const blankUrl = 'about:blank';
if (
win.location.href !== blankUrl ||
iframeEl.src === blankUrl ||
iframeEl.src === ''
) {
listener();
return;
}
// use default listener
iframeEl.addEventListener('load', listener);
}

function serializeNode(
n: Node,
options: {
Expand All @@ -215,18 +243,26 @@ function serializeNode(
maskInputOptions = {},
recordCanvas,
} = options;
// Only record root id when document object is not the base document
let rootId: number | undefined;
if (((doc as unknown) as INode).__sn) {
const docId = ((doc as unknown) as INode).__sn.id;
rootId = docId === 1 ? undefined : docId;
}
switch (n.nodeType) {
case n.DOCUMENT_NODE:
return {
type: NodeType.Document,
childNodes: [],
rootId,
};
case n.DOCUMENT_TYPE_NODE:
return {
type: NodeType.DocumentType,
name: (n as DocumentType).name,
publicId: (n as DocumentType).publicId,
systemId: (n as DocumentType).systemId,
rootId,
};
case n.ELEMENT_NODE:
const needBlock = _isBlockedElement(
Expand Down Expand Up @@ -318,6 +354,7 @@ function serializeNode(
if ((n as HTMLElement).scrollTop) {
attributes.rr_scrollTop = (n as HTMLElement).scrollTop;
}
// block element
if (needBlock) {
const { width, height } = (n as HTMLElement).getBoundingClientRect();
attributes = {
Expand All @@ -326,13 +363,18 @@ function serializeNode(
rr_height: `${height}px`,
};
}
// iframe
if (tagName === 'iframe') {
delete attributes.src;
}
return {
type: NodeType.Element,
tagName,
attributes,
childNodes: [],
isSVG: isSVGElement(n as Element) || undefined,
needBlock,
rootId,
};
case n.TEXT_NODE:
// The parent node may not be a html element which has a tagName attribute.
Expand All @@ -351,16 +393,19 @@ function serializeNode(
type: NodeType.Text,
textContent: textContent || '',
isStyle,
rootId,
};
case n.CDATA_SECTION_NODE:
return {
type: NodeType.CDATA,
textContent: '',
rootId,
};
case n.COMMENT_NODE:
return {
type: NodeType.Comment,
textContent: (n as Comment).textContent || '',
rootId,
};
default:
return false;
Expand Down Expand Up @@ -472,6 +517,8 @@ export function serializeNodeWithId(
slimDOMOptions: SlimDOMOptions;
recordCanvas?: boolean;
preserveWhiteSpace?: boolean;
onSerialize?: (n: INode) => unknown;
onIframeLoad?: (iframeINode: INode, node: serializedNodeWithId) => unknown;
},
): serializedNodeWithId | null {
const {
Expand All @@ -484,6 +531,8 @@ export function serializeNodeWithId(
maskInputOptions = {},
slimDOMOptions,
recordCanvas = false,
onSerialize,
onIframeLoad,
} = options;
let { preserveWhiteSpace = true } = options;
const _serializedNode = serializeNode(n, {
Expand Down Expand Up @@ -521,6 +570,9 @@ export function serializeNodeWithId(
return null; // slimDOM
}
map[id] = n as INode;
if (onSerialize) {
onSerialize(n as INode);
}
let recordChild = !skipChild;
if (serializedNode.type === NodeType.Element) {
recordChild = recordChild && !serializedNode.needBlock;
Expand Down Expand Up @@ -552,12 +604,44 @@ export function serializeNodeWithId(
slimDOMOptions,
recordCanvas,
preserveWhiteSpace,
onSerialize,
onIframeLoad,
});
if (serializedChildNode) {
serializedNode.childNodes.push(serializedChildNode);
}
}
}

if (
serializedNode.type === NodeType.Element &&
serializedNode.tagName === 'iframe'
) {
onceIframeLoaded(n as HTMLIFrameElement, () => {
const iframeDoc = (n as HTMLIFrameElement).contentDocument;
if (iframeDoc && onIframeLoad) {
const serializedIframeNode = serializeNodeWithId(iframeDoc, {
doc: iframeDoc,
map,
blockClass,
blockSelector,
skipChild: false,
inlineStylesheet,
maskInputOptions,
slimDOMOptions,
recordCanvas,
preserveWhiteSpace,
onSerialize,
onIframeLoad,
});

if (serializedIframeNode) {
onIframeLoad(n as INode, serializedIframeNode);
}
}
});
}

return serializedNode;
}

Expand All @@ -570,6 +654,9 @@ function snapshot(
slimDOM?: boolean | SlimDOMOptions;
recordCanvas?: boolean;
blockSelector?: string | null;
preserveWhiteSpace?: boolean;
onSerialize?: (n: INode) => unknown;
onIframeLoad?: (iframeINode: INode, node: serializedNodeWithId) => unknown;
},
): [serializedNodeWithId | null, idNodeMap] {
const {
Expand All @@ -579,6 +666,9 @@ function snapshot(
blockSelector = null,
maskAllInputs = false,
slimDOM = false,
preserveWhiteSpace,
onSerialize,
onIframeLoad,
} = options || {};
const idNodeMap: idNodeMap = {};
const maskInputOptions: MaskInputOptions =
Expand Down Expand Up @@ -632,6 +722,9 @@ function snapshot(
maskInputOptions,
slimDOMOptions,
recordCanvas,
preserveWhiteSpace,
onSerialize,
onIframeLoad,
}),
idNodeMap,
];
Expand Down
7 changes: 5 additions & 2 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,16 @@ export type commentNode = {
textContent: string;
};

export type serializedNode =
export type serializedNode = (
| documentNode
| documentTypeNode
| elementNode
| textNode
| cdataNode
| commentNode;
| commentNode
) & {
rootId?: number;
};

export type serializedNodeWithId = serializedNode & { id: number };

Expand Down
Loading

0 comments on commit 98aa732

Please sign in to comment.