Skip to content

Support for Nested Selectors, Nested Declarations and At-Rule Validations #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

acemir
Copy link

@acemir acemir commented May 16, 2025

This PR enhance the parser's ability to correctly process complex CSS structures, including nested selectors, nested declarations and at-rules with conditions.

Key Changes

Introducing CSS Nesting Module support

Improved At-Rule Validation

  • Refactored at-rule validation logic ensuring that invalid or malformed at-rules are ignored more reliably.
  • Improved handling of edge cases, such as unbalanced braces and complex at-rule conditions.
  • Enhanced handling of at-rules that cannot be nested.

Regex and Comment Clarifications

  • Updated and clarified several regular expressions and their associated comments for better maintainability and understanding.
  • Improved documentation for regexes used in whitespace and at-rule validation.

Test Improvements

  • Added tests for CSS Nesting and At-Rule Validations
  • Added failing tests for currently unsupported rules like CSSLayerStatementRule and imports with layer and supports

Motivation

These changes address issues with the parser's handling of nested CSS blocks and at-rules, making it more reliable with the current state of the browser's CSS implementations.

Impact

  • More accurate parsing of complex and nested CSS.
  • Better handling of invalid rules.
  • Improved code readability and maintainability.

Copy link

changeset-bot bot commented May 16, 2025

⚠️ No Changeset found

Latest commit: 9cae1fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@acemir
Copy link
Author

acemir commented May 19, 2025

Please, review @YunFeng0817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant