-
-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test
arg to AsyncValue.guard
#3292
Add test
arg to AsyncValue.guard
#3292
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3292 +/- ##
=======================================
Coverage 95.16% 95.16%
=======================================
Files 53 53
Lines 2295 2298 +3
=======================================
+ Hits 2184 2187 +3
Misses 111 111
|
Thanks for this! |
@@ -157,12 +157,24 @@ abstract class AsyncValue<T> { | |||
/// }); | |||
/// } | |||
/// } | |||
/// | |||
/// when predicate is provided, and it is false; rethrown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've edited the code-snippet. Explanation should be outside of the ```
Also, could you expand on it a bit more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I added it.
packages/riverpod/CHANGELOG.md
Outdated
@@ -2,6 +2,7 @@ | |||
|
|||
- Improved `Provider(dependencies: [...])` documentation. | |||
- Fix out of date `pub.dev` description | |||
- Add `predicate` argument to `AsyncValue.guard` method. (thanks to @utamori) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new feature. Update the heading to Unreleased minor
test
arg to AsyncValue.guard
LGTM, thanks! |
Related Issues
fixes #3291
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).I have updated the
CHANGELOG.md
of the relevant packages.Changelog files must be edited under the form:
If this contains new features or behavior changes,
I have updated the documentation to match those changes.