Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some additional lints #1569

Merged
merged 22 commits into from
Aug 23, 2022
Merged

Add some additional lints #1569

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
1deac6a
Add lints
rrousselGit Apr 18, 2022
6d5122c
update roadmap to contain what isn't inside issues
rrousselGit May 23, 2022
e605058
wip
rrousselGit May 27, 2022
d5852ae
Fix warning
rrousselGit Jun 7, 2022
7e3feb5
Update to custom_lint 0.0.5
rrousselGit Jun 7, 2022
b2d90a6
wip
rrousselGit Jun 9, 2022
614fe1d
Continue dependencies check
rrousselGit Jun 13, 2022
16c66d1
Update dependencies
rrousselGit Jun 13, 2022
79c5087
Update dependency and fix test
rrousselGit Jun 14, 2022
bc98253
rename riverpod_extra_dependency -> riverpod_unused_dependency
rrousselGit Jun 14, 2022
ebbf3a9
Handle dependency check when ref is passed to functions
rrousselGit Jun 14, 2022
71bd5aa
Remove pointless code
rrousselGit Jun 14, 2022
da281db
Start dependencies auto-fix
rrousselGit Jun 14, 2022
5fb463e
handle a few more cases
TimWhiting Aug 18, 2022
7554801
add a few more lint cases
TimWhiting Aug 19, 2022
73d394b
linter hot-reload support
TimWhiting Aug 20, 2022
b48d69a
fix code gen analyzer version
TimWhiting Aug 20, 2022
f043a74
fix other dependencies causing issues with linter branch
TimWhiting Aug 20, 2022
9e0e401
update example
TimWhiting Aug 20, 2022
84dae4a
fix merge changes
TimWhiting Aug 20, 2022
16faa43
start of synchronous mutation lint
TimWhiting Aug 22, 2022
239f9b8
gitignore
TimWhiting Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update example
  • Loading branch information
@TimWhiting
TimWhiting committed Aug 20, 2022
commit 9e0e40167b731acc7c9bbc7bec4f8bf3427d0323
3 changes: 3 additions & 0 deletions packages/riverpod/example/lib/models.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ class Repository {
'hash': hash,
},
);
if (result.data == null) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

return [];
}
final response = MarvelResponse.fromJson(result.data!);

return response //
Expand Down