Skip to content

Commit

Permalink
ARM: mvebu: fix suspend to RAM on big-endian configurations
Browse files Browse the repository at this point in the history
The current Armada XP suspend to RAM implementation, as added in
commit 2743282 ("ARM: mvebu: Armada XP GP specific
suspend/resume code") does not handle big-endian configurations
properly: the small bit of assembly code putting the DRAM in
self-refresh and toggling the GPIOs to turn off power forgets to
convert the values to little-endian.

This commit fixes that by making sure the two values we will write to
the DRAM controller register and GPIO register are already in
little-endian before entering the critical assembly code.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: <stable@vger.kernel.org> # v3.19+
Fixes: 2743282 ("ARM: mvebu: Armada XP GP specific suspend/resume code")
  • Loading branch information
tpetazzoni authored and gclement committed Jun 17, 2015
1 parent 885dbd1 commit 2f5bc30
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions arch/arm/mach-mvebu/pm-board.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ static void mvebu_armada_xp_gp_pm_enter(void __iomem *sdram_reg, u32 srcmd)
for (i = 0; i < ARMADA_XP_GP_PIC_NR_GPIOS; i++)
ackcmd |= BIT(pic_raw_gpios[i]);

srcmd = cpu_to_le32(srcmd);
ackcmd = cpu_to_le32(ackcmd);

/*
* Wait a while, the PIC needs quite a bit of time between the
* two GPIO commands.
Expand Down

0 comments on commit 2f5bc30

Please sign in to comment.