-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default upload tags and anonymous uploads #534
base: master
Are you sure you want to change the base?
Conversation
Hey, thanks for the work. I tried out some more changes for the UI. In replaced the input box with a TagInputControl (which gives tag colors, a list with a delete button, etc) and I added a collapsible expander. In the first version I only put the tags control in the expander, and in the second version I also put the options/checkboxes in an exapander. Obviously we also could just not use any expanders. Please tell me what you think (and others please do so as well if you have an opinion about this). |
Hey neo, thanks for the quick reply on this! I quite like your changes and (personally) I feel like the two dropdowns version looks better as it properly separates the options from the tags, as well as giving a proper section header for the user "Options" and "Common Tags", as opposed to my empty textbox without a label. |
Personally I would recommend the second one. Feels the neatest and cleanest if we're gonna do the upload choices not on one/two rows anymore. Ideal version would probably just be to add a new line and do two more in-line options but this looks fine too. |
Third version is the most flexible when adding new items or on a different font-size. The other two quickly start looking ugly if you need two lines for the option name. This currently is not the problem (on default font-size), but maybe in the future or on other font-sizes? I think the fifth version looks the best, but the rest is also okay. Opinions? |
My personal preference is the fifth version out of all of these. Flex wrap reeks a little bit too much of "this is chosen because its pretty easy". That said, I can also imagine that if we ever need to add more options, we can always revise this input box as necessary depending on what looks the best. Generally speaking these options are something you consciously enable anyway. Did you also check these on the small screen/mobile version? I doubt it's an issue, but if the font-size is different, then it might be useful to check if it still looks good there. |
It currently resizes like this. It's not perfect, but the only alternative would probably be to just put them underneath each other as soon as it doesn't fit inside a 2x2 grid anymore. firefox_2023_01_11_16_43_1083.mp4Source is available on neobooru:feature-534. I don't think I can add commits to this PR, so I'll probably manually squash and merge it. |
Hello,
I've taken the cherry-pick from noirscape's #468 , which was made by Hunternif@035ce19 and merged + tested it on my local environment, fixing an issue with tag name escaping as well.
Additionally, I added an option to mass upload posts anonymously, since if you are uploading a big mass of images it's annoying to mark all posts individually as anonymous. Due to there now being 4 checkboxes on the page, I've taken a bit of time to redesign the layout so it fits better.
These changes affect only the frontend and have all been tested on a local instance.