Fix incorrect JOIN/ON clause reconstruction#51
Merged
Conversation
Co-authored-by: otoolep <536312+otoolep@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Invalid JOIN/ON reconstruction
Fix incorrect JOIN/ON clause reconstruction
May 30, 2025
Member
|
@copilot -- run 'go fmt ./...' to format your source code. |
Co-authored-by: otoolep <536312+otoolep@users.noreply.github.com>
Contributor
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When parsing SQL statements with multiple JOIN clauses, the reconstructed SQL string (
Statement.String()) incorrectly ordered the JOIN and ON clauses. For example:The issue was in how the
JoinClause.String()method handled nested JOIN clauses created by the parser.Solution
This PR updates the
JoinClause.String()method to correctly handle the nested structure of JOIN clauses built by the parser. The solution specifically:The changes are minimal and focused on just the
JoinClause.String()method. Comprehensive tests were added to verify correct reconstruction of:Example
The reconstructed SQL now correctly maintains the proper ordering of JOIN and ON clauses:
Fixes #47.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.