Update cli.py #62
Merged
Update cli.py #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a simple solution to solve the issue. perhaps the rest of options would be helpful to supply with type too..
and issue rq#61
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 6 6
Lines 283 283
Branches 24 24
=======================================
Hits 282 282
Partials 1 1
Continue to review full report at Codecov.
|
|
@jezdez what's necessary to merge this PR? It seems to fix the problem with setting the poll interval value. |
src/flask_rq2/cli.py
Outdated
| @@ -118,8 +118,8 @@ def info(rq, ctx, path, interval, raw, only_queues, only_workers, by_queue, | |||
| @click.option('--name', '-n', help='Specify a different name') | |||
| @click.option('--path', '-P', default='.', help='Specify the import path.') | |||
| @click.option('--results-ttl', help='Default results timeout to be used') | |||
There was a problem hiding this comment.
It would be nice to also update this option with type=int and maybe a default.
Been noticing this error when providing a value or a similar error (instead of str complains about None) without providing a value.
File \"/usr/lib/python3.6/site-packages/rq/worker.py\", line 803, in perform_job
started_job_registry=started_job_registry)
File \"/usr/lib/python3.6/site-packages/rq/worker.py\", line 766, in handle_job_success
finished_job_registry.add(job, result_ttl, pipeline)
File \"/usr/lib/python3.6/site-packages/rq/registry.py\", line 43, in add
score = ttl if ttl < 0 else current_timestamp() + ttl
TypeError: '<' not supported between instances of 'str' and 'int'
", "exc_info": "Traceback (most recent call last):
File \"/usr/lib/python3.6/site-packages/rq/worker.py\", line 803, in perform_job
started_job_registry=started_job_registry)
File \"/usr/lib/python3.6/site-packages/rq/worker.py\", line 766, in handle_job_success
finished_job_registry.add(job, result_ttl, pipeline)
File \"/usr/lib/python3.6/site-packages/rq/registry.py\", line 43, in add
score = ttl if ttl < 0 else current_timestamp() + ttl
TypeError: '<' not supported between instances of 'str' and 'int'
This was referenced Sep 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a simple solution to solve the issues #58 and #61.
perhaps the rest of options would be helpful to supply with type too...