Skip to content

Support redis gem v5.x #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 1, 2023
Merged

Support redis gem v5.x #45

merged 3 commits into from
Aug 1, 2023

Conversation

benlangfeld
Copy link
Contributor

No description provided.

@sharang-d
Copy link
Contributor

Hi @benlangfeld, thanks for maintaining the rpush gems.

Can you please let me know if you have an estimate in mind for when this would be implemented? Or if there are any blockers?
Additionally, do let me know if I can help! I'd love to have the library support Redis 5+ because this library is the most recently updated library in the push-notification sending space and I'd love to keep it that way :)

@benlangfeld
Copy link
Contributor Author

Hi @benlangfeld, thanks for maintaining the rpush gems.

Can you please let me know if you have an estimate in mind for when this would be implemented? Or if there are any blockers? Additionally, do let me know if I can help! I'd love to have the library support Redis 5+ because this library is the most recently updated library in the push-notification sending space and I'd love to keep it that way :)

This is blocked on the failing tests here, and I don't have time to work on it. If someone can submit a version of this with passing tests, I can review it.

@sharang-d
Copy link
Contributor

I attempted something @ #47.

@sharang-d
Fix specs on Redis 5 (#47)
c552506 
This is my attempt at fixing the specs.

I know what is happening but I couldn't exactly tell WHY. So this patch
is more about fixing the problem but it may not be the best way to do it
as I couldn't identify the root cause.

I'm opening this to see if it triggers specs.
@rustemmukhamadiev
Copy link

@benlangfeld would be great to complete this PR and start support redis gem v5

@benlangfeld benlangfeld marked this pull request as ready for review August 1, 2023 13:21
@benlangfeld
Copy link
Contributor Author

Just need a changelog entry here which I'll add when I get to my desk.

@benlangfeld benlangfeld merged commit b2c7d95 into master Aug 1, 2023
@benlangfeld benlangfeld deleted the 20230201-redis-5 branch August 1, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benlangfeld @sharang-d @rustemmukhamadiev