-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test_version parameter to cli #394
base: main
Are you sure you want to change the base?
Conversation
…efault version of 0 with any build number from the cli
-1 from me. Commit_count is the number of commits since the last tagged version. When your workflow is git-commit/tito-build/rpm -U then commit_count assures that package is always upgradable (every subsequent release is bigger than the previous one). Although this breaks when you |
@xsuchy |
version = "git-%s.%s" % (self.commit_count, latest_commit[:7]) | ||
if self.test_version is None: | ||
self.test_version = get_commit_count(self.build_tag, latest_commit) | ||
version = "git-%s.%s" % (self.test_version, latest_commit[:7]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 LGTM now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Changes made:
Fixes #332