Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Own dirs and files that dnf5 creates on runtime #65

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

tpgxyz
Copy link
Contributor

@tpgxyz tpgxyz commented Sep 27, 2022

Own dirs and files that dnf5 creates on runtime inside spec file so rpm can be aware of that fles

@m-blaha
Copy link
Member

m-blaha commented Oct 4, 2022

Can you rebase please? Your PR now conflicts with recent changes of dnf.spec file.

@inknos inknos self-requested a review October 26, 2022 11:58
@tpgxyz tpgxyz closed this Oct 27, 2022
@tpgxyz tpgxyz deleted the sysimage branch October 27, 2022 15:51
@tpgxyz tpgxyz restored the sysimage branch October 27, 2022 15:52
@tpgxyz tpgxyz reopened this Oct 27, 2022
@tpgxyz
Copy link
Contributor Author

tpgxyz commented Oct 27, 2022

@m-blaha Hi, sorry for the delay, hope i rebased it right.

@tpgxyz tpgxyz requested review from m-blaha and removed request for inknos October 27, 2022 16:01
@m-blaha
Copy link
Member

m-blaha commented Nov 8, 2022

Oh sorry - I wasn't available last week and now... another rebase is needed. Sorry for inconvenience again :(

@inknos
Copy link
Collaborator

inknos commented Nov 29, 2022

@tpgxyz hi!

another rebase is needed.

Could you please rebase the pr again?

@m-blaha I am taking over the review if you don't mind.

@inknos inknos self-assigned this Nov 29, 2022
@inknos inknos requested review from inknos and removed request for m-blaha November 29, 2022 12:28
@inknos
Copy link
Collaborator

inknos commented Feb 13, 2023

hi, I just rebased your pr to be merged. no other change from my side. thank you for the contribution and please excuse the long time taken from me

@inknos inknos merged commit f8e861b into rpm-software-management:main Feb 13, 2023
@tpgxyz tpgxyz deleted the sysimage branch February 17, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants