Make distrosync as a targeted operation #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All candidates for distrosync transaction are provided by DNF, therefore we have to force libsolv to use only those candidates for the job solution => make job TARGETED. When job is not marked explicitly as TARGETED, libsolv try to auto-detect TARGETED job. As a key it uses presence or absence of installed packages (from @System repository) in the provided set of candidates. If no installed package in the set, it handles the job as TARGETED. TARGETED means that only packages in the provided set can be use for a solution of the job. The patch unify upgrade and distrosync flags in DNF5 => using SOLVER_TARGETED. Resolves: rpm-software-management#222
|
It would be great to have a CI test for case. |
Good point |
|
What about a test - rpm-software-management/ci-dnf-stack#1211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNF provides all candidates for transaction to libsolv, therefore we have to force libsolv to use only those candidates for the job solution => to make job TARGETED. If distrosync or upgrade job is not marked as TARGETED explicitly, libsolv mark as TARGETED job without installed package in the set of candidates.
The patch unify upgrade and distrosync flags in DNF5 => using SOLVER_TARGETED.
Resolves: #222