Fix repository specific excludes

[m-blaha]

rq.filter_id(disable_excludes, libdnf::sack::QueryCmp::NOT_GLOB) in case of empty disable_excludes filters out all repositories.

Resolves #233

[m-blaha]

There is also another way how to fix it.

What is the desired behavior of bool match_string(const std::string & value, QueryCmp cmp, const std::vector<std::string> & patterns) function in case the patterns vector is empty and the cmp comparator is negative? - e.g. rq.filter_id([], libdnf::sack::QueryCmp::NOT_GLOB) in this issue, which leads to match_string(repo_id, libdnf::sack::QueryCmp::NOT_GLOB, [])

I believe it should return true. Any comments?

dnf5/libdnf/common/sack/match_string.cpp

Lines 88 to 97 in 1329442

	bool match_string(const std::string & value, QueryCmp cmp, const std::vector<std::string> & patterns) {
	bool result = false;
	for (auto & pattern : patterns) {
	if (match_string(value, cmp, pattern)) {
	result = true;
	break;
	}
	}
	return result;
	}

[kontura]

I believe it should return true. Any comments?

It would also make sense to me. It seems like a cleaner solution, especially since we have tests for this.
If we modify match_string() I would also change match_int64() in the same way.

[m-blaha]

I tried to fix the behavior of match_string() function in case one (or both) of operands are vectors and the cmp operator is negative. I tried to describe the new behavior both in commit message and in the comments.
The fix for match_int64() is still not present, but I'd appreciate a partial review here - to make sure that the logic change makes sense.

[kontura]

The PR looks good, but I think that in the commit msg: match_string("fedora", NOT_GLOB, ["fedora", "testing"]) would return true is wrong. "fedora" is in the string list and since we use NOT_ it would return false no?

[m-blaha]

I should have written the commit message more clearly. The part you mentioned is an example of clearly wrong behaviour of current (unfixed by this pach) implementation. Let me try to re-formulate the commit message.

[kontura]

I see, thanks, it is much more understandable for me now.