Install spec implementation #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-blaha
force-pushed
the
mblaha/install_spec
branch
2 times, most recently
from
13f0158 to
d9e3532
Compare
m-blaha
force-pushed
the
mblaha/install_spec
branch
2 times, most recently
from
e03fbbd to
a39689f
Compare
jrohel
reviewed
Jan 19, 2023
jrohel
reviewed
Jan 19, 2023
jrohel
reviewed
Jan 19, 2023
jrohel
reviewed
Jan 19, 2023
j-mracek
reviewed
Jan 19, 2023
| /// High level API for an artifact reinstall. See `add_install()` for details. | ||
| /// @param spec A string with reinstall spec | ||
| /// @param settings A structure to override default goal settings. | ||
| void add_reinstall(const std::string & spec, const libdnf::GoalJobSettings & settings = libdnf::GoalJobSettings()); |
There was a problem hiding this comment.
Reinstall and downgrade operation was not supported by DNF4. With groups it somehow make sene, but with module I am really nor sure what it is supposed to do (too many edge cases).
There was a problem hiding this comment.
There was an assert preventing libdnf to perform some actions on groups. Actually currently only INSTALL and REMOVE actions are supported.
I've added commits to change this assert and a resolve log is written instead.
New API method add_cmdline_packages accepts a vector of local rpm file paths or URLs of remote rpms. The remote packages are downloaded and all are inserted into cmdline repository. Currently filling of the cmdline repository is responsibility of the user which leads to code duplication - each client needs to implement it's own download methods.
This implements install/reinstall/upgrade/downgrade/remove actions on any artifact using the same high level API functions goal.add_*(spec). The spec here can be - a repository package specification matched against NEVRA, provides, and file provides, e.g. "wget", "vim-*" - a local rpm file (/the/location/package.rpm) - a URL of remote rpm package - using '@' prefix also a group can be specified - @rpm-development-tools - TODO: once installation of environmental groups and modules is implemented, also these artifact will be fully supported
With new goal.add_*(spec) API usage dnf5 does not need to fill cmdline repo any more.
Adding packages to cmdline repo was moved to RepoSack.
With new API to add packages to cmdline repo there is no external user for this method.
This problem is logged if user wants to perform goal action, which is not supported - e.g. downgrading a group.
Now with the install spec there is a way for the API users to ask libdnf
to perform unsupported operations - for example
`goal.add_downgrade('@group_id')`.
We need to inform the user what's wrong instead of throwing an exception.
m-blaha
force-pushed
the
mblaha/install_spec
branch
from
a39689f to
21b37bc
Compare
|
Hm, some CI tests started failing. I need to investigate it. |
m-blaha
added
blocked
In case dnf was downloading some remote rpm files from URL, the transaction table was printed right on the last line of the multiprogress bar.
jrohel
force-pushed
the
mblaha/install_spec
branch
from
6df8b75 to
165b73c
Compare
m-blaha
added
ready for review
and removed
blocked
|
Thank you for the PR and cooperation. |
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New high level API for installing any artifact using the same simple call goal.add_install(spec).
The spec here can be