Fix parsing of offline transaction JSON file #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't the same bug few lines above when parsing "groups" and when parsing "environments"? |
|
Oh, good catch. I'll add it to the fix. |
Initialize the action, nevra, reason, repo_id, group_id, and package_path fields to empty strings for each package, when parsing transaction JSON file. Without this initialization, these fields may retain values from the previous loop iteration, leading to an incorrect transaction. Similar issue is fixed also for groups and environments parsing. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2322527
m-blaha
force-pushed
the
mblaha/offline-parsing
branch
from
732ac10 to
65f9c2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize the action, nevra, reason, repo_id, group_id, and package_path
fields to empty strings for each package, when parsing transaction JSON
file. Without this initialization, these fields may retain values
from the previous loop iteration, leading to an incorrect transaction.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2322527