Remove extra allocation in get_file_paths #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
reviewed
Jul 17, 2024
src/rpm/package.rs
Outdated
| @@ -770,7 +770,9 @@ impl PackageMetadata { | |||
| |mut acc, item| { | |||
| let (basename, dir_index) = item; | |||
| if let Some(dir) = dirs.get(dir_index as usize) { | |||
| acc.push(PathBuf::from(dir).join(basename)); | |||
| let mut path = PathBuf::from(dir); | |||
| path.push(basename); | |||
There was a problem hiding this comment.
Is it possible to do Path::from(dir).join(basename) instead? I believe that would also avoid the extra allocation, and perhaps more reliably.
There was a problem hiding this comment.
Good point, changed!
I was able to measure a difference for debuginfod-rs:
```
Time (mean ± σ): 2.303 s ± 0.017 s [User: 25.220 s, System: 5.214 s]
Range (min … max): 2.272 s … 2.327 s 10 runs
Warning: Ignoring non-zero exit code.
Benchmark 2: /tmp/after3
Time (mean ± σ): 2.298 s ± 0.028 s [User: 24.979 s, System: 5.310 s]
Range (min … max): 2.241 s … 2.331 s 10 runs
Warning: Ignoring non-zero exit code.
Summary
/tmp/after3
1.00 ± 0.01 times faster than /tmp/before
```
marxin
force-pushed
the
get_file_paths-reduce-PathBuf-allocation
branch
from
ada38bb
to
2008114
Compare
dralley
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to measure a difference for debuginfod-rs: