Skip to content

Commit

Permalink
docs(Modal): update props' description (Semantic-Org#4291)
Browse files Browse the repository at this point in the history
* Update Modal.js

I suppose Modal is just a specialized Portal (or vice-versa?) but I suppose props docs for modal could be less ambiguous with these small changes.

* Update src/modules/Modal/Modal.js

Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
  • Loading branch information
bonellia and layershifter authored Jan 14, 2022
1 parent 848f497 commit e34b68a
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions src/modules/Modal/Modal.js
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ Modal.propTypes = {
onClose: PropTypes.func,

/**
* Called when the portal is mounted on the DOM.
* Called when the modal is mounted on the DOM.
*
* @param {null}
* @param {object} data - All props.
Expand All @@ -357,7 +357,7 @@ Modal.propTypes = {
onOpen: PropTypes.func,

/**
* Called when the portal is unmounted from the DOM.
* Called when the modal is unmounted from the DOM.
*
* @param {null}
* @param {object} data - All props.
Expand All @@ -373,12 +373,12 @@ Modal.propTypes = {
/** Custom styles. */
style: PropTypes.object,

/** Element to be rendered in-place where the portal is defined. */
/** Element to be rendered in-place where the modal is defined. */
trigger: PropTypes.node,

/**
* NOTE: Any unhandled props that are defined in Portal are passed-through
* to the wrapping Portal.
* NOTE: Any unhandled props that are defined in Modal are passed-through
* to the inner Portal.
*/
}

Expand Down

0 comments on commit e34b68a

Please sign in to comment.