maxHeight no scrollbar

[1v]

When adding maxHeight and text has many lines - scroll bar in textarea is not appears because overflow-y: hidden; added to textarea.

[rpearce]

@1v can you please provide a project demo that demonstrates this issue? That would be very helpful!

[elitenoire]

This is true.
You can use the storybook example, opening devtools and applying a max-height smaller than the height of the textarea element.
You'll notice the absence of the scrollbar making the area not to scroll.
Toggling off the overflow-y: hidden style enables scroll.

[rpearce]

@elitenoire thank you for walking me through exactly how to reproduce the issue. I'll see what I can do

[rpearce]

I started looking into this and didn't see a quick solution; I apologize for the delay. I've been working extensively on rpearce/react-medium-image-zoom#244 in my spare time and haven't made time for this yet.

If anybody cares to open a PR that fixes this and does not regress other issues, that would definitely speed this along!

[chrisdrackett]

running into something similar but the height is handed outside of the textarea I might have time to take a look at both tomorrow

[rpearce]

Any help is appreciated!

[rpearce]

@chrisdrackett did you find a solution to this that you could share?

It seems like if there is a maxHeight defined, and the scrollHeight is taller than the maxHeight, then the overflow-y: hidden should be removed. Sound logical?

[rpearce]

@1v @elitenoire @chrisdrackett This should be resolved in v2.2.3, and you can check it out here: https://rpearce.github.io/react-expanding-textarea/?path=/story/expandingtextarea--with-max-height.

If you have any more issues with this, I will reopen the issue.

Thank you all for your contributions by reporting this! I've added you to the all contributors list in the README.