This repository was archived by the owner on Dec 27, 2018. It is now read-only.
I found the requirements.txt to be too lax #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was unable to execute ```python from PythonConfluenceAPI import ConfluenceAPI ``` until this dependency was resolved. Happy Hacking, esc
requirements.txt too lax
burkestar
reviewed
Feb 12, 2017
| @@ -6,3 +6,4 @@ future>=0.15.2 | |||
| futures>=3.0.3,<4 | |||
| requests[security]>=2.3.0,<3 | |||
| requests-futures>=0.9.5,<1 | |||
| future>=0.15.2,<1 | |||
There was a problem hiding this comment.
probably should specify the range on line 5 instead of duplicating the requirement.
|
Also, to cleanly pip install this package into a new virtualenv, the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was unable to execute
until this dependency was resolved.
Happy Hacking,
esc