Skip to content

Fix broken link to team list #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Fix broken link to team list #609

merged 1 commit into from
Jul 5, 2023

Conversation

tommy-gilligan
Copy link
Contributor

I did a quick check of other links. http://citizencodeofconduct.org is also broken right now but seems like it is maybe temporary.

I did a quick check of other links.  http://citizencodeofconduct.org is also
broken right now but seems like it is maybe temporary.
@jannic
Copy link
Member

jannic commented May 15, 2023

Thanks for notifying us of the broken link!
The change LGTM, but before merging, I'll ask around if the list at https://github.com/orgs/rp-rs/people is really correct.

The old link, https://github.com/orgs/rp-rs/teams/rp-rs, is not really non-existing, but it's a private page only visible to team members, so you're right that it's not useful to link to it from the public page.

However, the new link doesn't list the same people, but a larger group.

It's probably fine, as we don't have a formal process defining who is member of the team anyways, but I still don't want do decide it on my own. Especially as I'm not one of the people listed on https://github.com/orgs/rp-rs/teams/rp-rs.

@tommy-gilligan
Copy link
Contributor Author

The old link, https://github.com/orgs/rp-rs/teams/rp-rs, is not really non-existing, but it's a private page only visible to team members

Thank you for correcting my misunderstanding. I totally just assumed that GitHub had changed their paths at some point.

@jannic
Copy link
Member

jannic commented May 15, 2023

I did a quick check of other links. http://citizencodeofconduct.org is also broken right now but seems like it is maybe temporary.

Looks like it's not a temporary issue: rust-lang/www.rust-lang.org#1215

@ithinuel ithinuel added the documentation Improvements or additions to documentation label May 16, 2023
Copy link
Member

@9names 9names left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the outcome here is that rp-rs/people might not be perfectly accurate, but it's what we have and better than the broken link.
LGTM

@tommy-gilligan
Copy link
Contributor Author

Don't know what to do about this other link http://citizencodeofconduct.org/ .

Linking to a copy at somebody else's GH repo doesn't seem particularly stable. rust-lang/www.rust-lang.org#1215

If it's currently broken it might make sense to remove it for now.

I'm just going to go with ignoring it.

@jannic jannic merged commit 3b2738a into rp-rs:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants