-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing k256 kat_tests #67
base: unstable-k256
Are you sure you want to change the base?
Conversation
73dc13d
to
04fe179
Compare
I believe adding this test brings k256 up to feature parity with the others. Is anything else blocking it from being merged into main as a feature? Linking to the secp256k1 DHKEM author's note on why it probably will not make it into an RFC even though it's ready for action.
|
04fe179
to
865adf3
Compare
Known Answer Tests are missing in the original k256 implementation on the unstable-k256 branch.
There are a couple of things to solve in order to get them in here.
test-vectors-5f503c5.json
generated from the reference implementation do not include known answers for k256 since it is not defined in RFC 9080skRm
andskSm
are the identical butikmS
andikmR
from which they are derived (afaiu) are different as discussed in hpke-rs h/t @franziskuskiefer for discovering this.I'm working on generating test vectors and having another implementation test them as well.