- fix: Class browser is empty when ctrl+click to open a file.

royqh1979 · Dec 21, 2024 · eeba1f5 · eeba1f5
1 parent dfe915e
commit eeba1f5
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 7 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -19,6 +19,7 @@ Red Panda C++ Version 3.3
   - enhancement: Add the option "Clear symbols in hidden source files" in option / environment / performance. (Turned on by default)
   - enhancement: Treat .tcc file as C/C++ header file.
   - enhancement: Save encoding / filetype /context file infos of last openned files.
+  - fix: Class browser is empty when ctrl+click to open a file.
 
 Red Panda C++ Version 3.2
 

diff --git a/RedPandaIDE/editor.cpp b/RedPandaIDE/editor.cpp
@@ -1502,17 +1502,13 @@ void Editor::showEvent(QShowEvent */*event*/)
                 this,
                 &Editor::onEndParsing);
         if (!pMainWindow->openingFiles() && !pMainWindow->openingProject()) {
-            bool needReparse=((isC_CPPHeaderFile(mFileType)
-                               && !mContextFile.isEmpty()
-                               && !mParser->isFileParsed(mContextFile))
-                                || (!mParser->isFileParsed(mFilename)));
             if (pSettings->codeCompletion().clearWhenEditorHidden()
                 && pSettings->codeCompletion().shareParser()
                 && !inProject()) {
-                if (needReparse)
+                if (needReparse())
                     resetCppParser(mParser);
             }
-            if (needReparse) {
+            if (needReparse()) {
                 reparse(false);
             }
         }
@@ -4613,10 +4609,20 @@ Editor* Editor::openFileInContext(const QString &filename)
                 e->setContextFile(mContextFile);
             }
         }
+        if (e->isVisible())
+            pMainWindow->updateClassBrowserForEditor(e);
     }
     return e;
 }
 
+bool Editor::needReparse()
+{
+    return mParser && ((isC_CPPHeaderFile(mFileType)
+                        && !mContextFile.isEmpty()
+                        && !mParser->isFileParsed(mContextFile))
+                       || (!mParser->isFileParsed(mFilename)));
+}
+
 const QString &Editor::contextFile() const
 {
     return mContextFile;

diff --git a/RedPandaIDE/editor.h b/RedPandaIDE/editor.h
@@ -331,6 +331,7 @@ private slots:
     void doSetFileType(FileType newFileType, bool force=false);
 
     Editor* openFileInContext(const QString& filename);
+    bool needReparse();
 
 private:
     bool mInited;

diff --git a/RedPandaIDE/mainwindow.cpp b/RedPandaIDE/mainwindow.cpp
@@ -1627,7 +1627,6 @@ void MainWindow::updateClassBrowserForEditor(Editor *editor)
             return;
         }
 
-
         mClassBrowserModel->beginUpdate();
         mClassBrowserModel->setParser(editor->parser());
         if (editor->inProject()) {
-Original file line number
+Diff line change
@@ Expand Up @@
                 return;
             }
             mClassBrowserModel->beginUpdate();
             mClassBrowserModel->setParser(editor->parser());
             if (editor->inProject()) {
@@ Expand Down @@