Skip to content

Conversation

@IRus
Copy link
Contributor

@IRus IRus commented Nov 1, 2016

Hi, @roylee0704

Since i, and other user of your great project uses TypeScript, i added definition for your project.
Hope will be merged and released patch version soon 👍

@IRus
Copy link
Contributor Author

IRus commented Nov 9, 2016

Hi @roylee0704! Any concerns about this PR?

@roylee0704
Copy link
Owner

Nope @IRus, LGTM. :) Apologize that i only notice now.

@roylee0704
Copy link
Owner

I will merge and release once I have access to my laptop :) thanks for the PR!

@IRus
Copy link
Contributor Author

IRus commented Nov 21, 2016

What's up :)

@beckend
Copy link
Contributor

beckend commented Nov 24, 2016

Can you fix the typings according to issue

@IRus
Copy link
Contributor Author

IRus commented Nov 24, 2016

@beckend sure

@IRus
Copy link
Contributor Author

IRus commented Nov 25, 2016

@beckend
Copy link
Contributor

beckend commented Nov 25, 2016

Looks good, wait for maintainer to merge.

@maxcan
Copy link

maxcan commented Jan 28, 2017

@roylee0704 are you open to this PR? If so I'll work on cleaning up the dependencies

@silvenon
Copy link
Collaborator

silvenon commented Feb 13, 2017

@IRus I don't know TypeScript, but I see no reason not to merge this if you can confirm that this PR is complete considering the latest changes. 👍

@IRus
Copy link
Contributor Author

IRus commented Feb 13, 2017

@silvenon cheking

@IRus
Copy link
Contributor Author

IRus commented Feb 13, 2017

@silvenon renamed types according latest changes. Props looks good.

@silvenon silvenon merged commit 4dc4913 into roylee0704:master Feb 13, 2017
@silvenon silvenon mentioned this pull request Feb 20, 2017
@cyberhck
Copy link

Thanks for the TypeDefinition, I noticed you added tests, but I'm not sure if they're even being run, can you weigh in here? 🙂

@IRus
Copy link
Contributor Author

IRus commented Aug 1, 2017

@cyberhck Nice question! No, they didn't. On CI at least. But locally you can try to compile or open in webstorm/vscode to check that definitions works properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants