-
Notifications
You must be signed in to change notification settings - Fork 204
Add TypeScript definitions support #62. #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @roylee0704! Any concerns about this PR? |
|
Nope @IRus, LGTM. :) Apologize that i only notice now. |
|
I will merge and release once I have access to my laptop :) thanks for the PR! |
|
What's up :) |
|
Can you fix the typings according to issue |
|
@beckend sure |
|
Looks good, wait for maintainer to merge. |
|
@roylee0704 are you open to this PR? If so I'll work on cleaning up the dependencies |
|
@IRus I don't know TypeScript, but I see no reason not to merge this if you can confirm that this PR is complete considering the latest changes. 👍 |
|
@silvenon cheking |
|
@silvenon renamed types according latest changes. Props looks good. |
|
Thanks for the TypeDefinition, I noticed you added tests, but I'm not sure if they're even being run, can you weigh in here? 🙂 |
|
@cyberhck Nice question! No, they didn't. On CI at least. But locally you can try to compile or open in webstorm/vscode to check that definitions works properly. |
Hi, @roylee0704
Since i, and other user of your great project uses TypeScript, i added definition for your project.
Hope will be merged and released patch version soon 👍