fixed PCS API error: Can't get the error when upload failed

royaso · May 6, 2014 · 78199d2 · 78199d2
1 parent 34612e4
commit 78199d2
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/pcs/pcs.c b/pcs/pcs.c
@@ -1321,7 +1321,7 @@ static PcsFileInfo *pcs_upload_form(Pcs handle, const char *path, PcsBool overwr
 	char *url, *html,
 		*dir = pcs_utils_basedir(path),
 		*filename = pcs_utils_filename(path);
-	cJSON *json;
+	cJSON *json, *item;
 	PcsFileInfo *meta;
 
 	url = pcs_http_build_url(pcs->http, URL_PCS_REST,
@@ -1349,6 +1349,18 @@ static PcsFileInfo *pcs_upload_form(Pcs handle, const char *path, PcsBool overwr
 		pcs_set_errmsg(handle, "Can't parse the response as json: %s", html);
 		return NULL;
 	}
+	//"{\"error_code\":31062,\"error_msg\":\"file name is invalid\",\"request_id\":3071564675}
+	item = cJSON_GetObjectItem(json, "error_code");
+	if (item) {
+		int error_code = item->valueint;
+		const char *error_msg = NULL;
+		item = cJSON_GetObjectItem(json, "error_msg");
+		if (item)
+			error_msg = item->valuestring;
+		pcs_set_errmsg(handle, "Can't upload file. error_code: %d, error_msg: %s, raw response: %s", error_code, error_msg, html);
+		cJSON_Delete(json);
+		return NULL;
+	}
 
 	meta = pcs_parse_fileinfo(json);
 	cJSON_Delete(json);

diff --git a/pcs/pcs.h b/pcs/pcs.h
@@ -9,7 +9,7 @@
 #include "pcs_slist.h"
 #include "pcs_utils.h"
 
-#define PCS_API_VERSION "v1.0.0"
+#define PCS_API_VERSION "v1.0.1"
 
 typedef enum PcsOption {
 	PCS_OPTION_END = 0,