Fix tabular data got removed

royalgarter · Mar 1, 2019 · 6a5066a · 6a5066a
1 parent f70d368
commit 6a5066a
Show file tree

Hide file tree

Showing 4 changed files with 1,543 additions and 1 deletion.
diff --git a/Readability.js b/Readability.js
@@ -1628,11 +1628,16 @@ Readability.prototype = {
     //
     // TODO: Consider taking into account original contentScore here.
     this._removeNodes(e.getElementsByTagName(tag), function(node) {
-      // First check if we're in a data table, in which case don't remove us.
+      // First check if this node IS data table, in which case don't remove it.
       var isDataTable = function(t) {
         return t._readabilityDataTable;
       };
 
+      if (tag === "table" && isDataTable(node)) {
+        return false;
+      }
+
+      // Next check if we're inside a data table, in which case don't remove it as well.
       if (this._hasAncestorTag(node, "table", -1, isDataTable)) {
         return false;
       }

diff --git a/test/test-pages/keep-tabular-data/expected-metadata.json b/test/test-pages/keep-tabular-data/expected-metadata.json
@@ -0,0 +1,7 @@
+{
+  "title": "Friday Facts #282 - 0.17 in sight | Factorio",
+  "byline": null,
+  "excerpt": "Posted by kovarex, TOGos, Ernestas, Albert on 2019-02-15, all posts",
+  "readerable": true,
+  "siteName": "Factorio.com"
+}