-
Notifications
You must be signed in to change notification settings - Fork 358
Cli to dev #309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Cli to dev #309
Conversation
tusharmagar
commented
Nov 20, 2025
- added better prompting
- updated example
- added --sync-example to get rowboat examples
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
apps/cli/bin/app.js
Outdated
| const imported = await importExample(exampleName); | ||
|
|
||
| // Build output message | ||
| const output = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets move all of this post-processing inside importExample() itself
- remove output messages from app.js and moved them into importExample
apps/cli/bin/app.js
Outdated
| } | ||
| ) | ||
| .command( | ||
| "list-example", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should be list-examples (plural)
apps/cli/bin/app.js
Outdated
| } | ||
| ) | ||
| .command( | ||
| "sync-example <example>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: should be called import-example <name>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to remove the diff for this file