Minor documentation modifications for discrimination: Adding required checkpoint path and explicit parameter counts. #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Rowan, thanks for the awesome repo.
I was just running through
run_discriminator.pywith the prebuilt models and noticed a couple minor issues in the discrimination documentation.The code is checking explicitly for the for the "checkpoint" file (and will fail without it), but these aren't listed for download in the discrimination README. I've added the GCS URL for the corresponding checkpoint for each model.
The discrimination README refers to Grover "medium", while the paper refers to Grover "large". This isn't a big deal (it's analogous to GPT-2 "medium", so I understand why it's referred to as "medium" here). I did spend a bit of time trying to make sure I had the right model, so I thought it might be helpful to include the parameter counts to clarify.
Thanks again,
Evan