add additional parameters to signing request #267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository owner
deleted a comment from
mv-vrajroham
Dec 13, 2017
Collaborator
|
@gborcherds Awesome work and indeed feature for signing url request. |
Collaborator
|
@gborcherds I have released latest version of component with this PR. Now you can enjoy your feature in 3.0.3 |
Contributor
Author
|
Thanks, I appreciate the addition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this pull request. I updated the docs to talk about the three parameters for the signing request that need to be done and I added formData to the signing request. These gives someone full control over the signing request, which is my case is needed and may be needed by others.
Let me know if you want me to change anything.