feat(codex): prefer upstream websockets for responses#3562
Open
hemo94931 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the codex-prefer-upstream-websockets configuration option, allowing ordinary HTTP/SSE requests to prefer Codex credentials configured with websockets and utilize the upstream websocket transport. It adds context helpers to propagate this preference, updates the CodexAutoExecutor to route requests accordingly, and modifies the scheduler and selector logic to prioritize websocket-enabled credentials when the preference is active. Additionally, comprehensive unit tests have been added to verify the new behavior. I have no feedback to provide as there are no review comments to address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
配置项中添加:codex-prefer-upstream-websockets: false
用于控制 codex下游http/sse连接cpa时,cpa是否使用websocket与OpenAI建立连接(需要auth的json文件配置"websockets":true,否则回退为http)