fix(openai-compat): inherit static thinking support#3560
fix(openai-compat): inherit static thinking support#3560shoucandanghehe wants to merge 3 commits into
Conversation
|
This pull request targeted The base branch has been automatically changed to |
There was a problem hiding this comment.
Code Review
This pull request updates the OpenAI compatibility model configuration to reuse static model definitions for thinking/reasoning capabilities when available, falling back to default levels if not. It also updates the model hash computation to include the thinking configuration and adds corresponding unit tests. The reviewer suggested avoiding a redundant lookup in buildOpenAICompatibilityConfigModels when modelID is identical to name.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a262f58612
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Summary
Tests
go test ./sdk/cliproxy ./internal/watcher/diffgo build -o test-output ./cmd/server && rm test-outputgit diff --check