Skip to content

fix(openai-compat): inherit static thinking support#3560

Open
shoucandanghehe wants to merge 3 commits into
router-for-me:devfrom
shoucandanghehe:fix/openai-compat-static-thinking
Open

fix(openai-compat): inherit static thinking support#3560
shoucandanghehe wants to merge 3 commits into
router-for-me:devfrom
shoucandanghehe:fix/openai-compat-static-thinking

Conversation

@shoucandanghehe
Copy link
Copy Markdown

Summary

  • Inherit static model thinking support for OpenAI-compatible configured models before falling back to the generic low/medium/high default
  • Include OpenAI-compatible model thinking metadata in the hot-reload model hash
  • Add regressions for gpt-5.5 xhigh inheritance and thinking hash changes

Tests

  • go test ./sdk/cliproxy ./internal/watcher/diff
  • go build -o test-output ./cmd/server && rm test-output
  • git diff --check

@github-actions github-actions Bot changed the base branch from main to dev May 26, 2026 06:05
@github-actions
Copy link
Copy Markdown

This pull request targeted main.

The base branch has been automatically changed to dev.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the OpenAI compatibility model configuration to reuse static model definitions for thinking/reasoning capabilities when available, falling back to default levels if not. It also updates the model hash computation to include the thinking configuration and adds corresponding unit tests. The reviewer suggested avoiding a redundant lookup in buildOpenAICompatibilityConfigModels when modelID is identical to name.

Comment thread sdk/cliproxy/service.go Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a262f58612

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread sdk/cliproxy/service.go
Comment thread sdk/cliproxy/service.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant