forked from aviator/aviator
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove the requirement to authenticate before calling a service object
There is no reason for Session#get_service_obj to require authentication and it can do its job perfectly without it. The only reason I can see it doing that is so that Service#request doesn't crash. However, upon looking at Service#request, it already has the necessary checks to ensure it has the data it needs. I did, however, add a more helpful error message in cases where the client code did forget to initialize the session data before calling Service#request.
- Loading branch information
1 parent
adff9f5
commit 6ae573e
Showing
3 changed files
with
18 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters