Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compare both email and name before skipping vcard import #9606

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

johndoh
Copy link
Contributor

@johndoh johndoh commented Aug 25, 2024

for #9592

compare both the email address and the name of a contact (when available) before declaring it a duplicate

@pabzm
Copy link
Member

pabzm commented Aug 26, 2024

Thanks for the contribution! But is #9513 really the correct reference? I don't understand how this related to that.

@johndoh
Copy link
Contributor Author

johndoh commented Aug 26, 2024

sorry. I have corrected the reference.

@pabzm pabzm requested review from pabzm and alecpl September 3, 2024 15:13
Copy link
Member

@pabzm pabzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 👍

(The CI errors are not your concern.)

@pabzm
Copy link
Member

pabzm commented Sep 12, 2024

@alecpl FYI: I'll merge this in a few days unless you object.

@alecpl
Copy link
Member

alecpl commented Sep 12, 2024

I don't have a strong opinion, you can merge. Maybe something like "import/merge strategy" feature, where user would pick how to handle potential duplicates (before or after upload), would solve this better.

@pabzm
Copy link
Member

pabzm commented Sep 12, 2024

Maybe something like "import/merge strategy" feature, where user would pick how to handle potential duplicates (before or after upload), would solve this better.

@alecpl I agree that that would be another improvement, but I think this current change is one step forward already and thus merge it now. Thank you for the feedback!

@pabzm pabzm merged commit 6b64eab into roundcube:master Sep 12, 2024
17 of 18 checks passed
@johndoh johndoh deleted the vcard_import2 branch September 14, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants