Fix regression, cleanup

roundcube · Apr 1, 2024 · 4959abe · 4959abe
1 parent 47172b4
commit 4959abe
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/plugins/zipdownload/zipdownload.php b/plugins/zipdownload/zipdownload.php
@@ -141,8 +141,6 @@ public function download_attachments()
         $zip->open($tmpfname, ZipArchive::OVERWRITE);
 
         foreach ($message->attachments as $part) {
-            $pid = $part->mime_id;
-            $part = $message->mime_parts[$pid];
             $disp_name = $this->_create_displayname($part);
 
             $tmpfn = rcube_utils::temp_filename('zipattach');

diff --git a/program/lib/Roundcube/rcube_message.php b/program/lib/Roundcube/rcube_message.php
@@ -1049,8 +1049,8 @@ private function get_mime_numbers(&$part)
             $this->mime_parts[$part->mime_id] = &$part;
         }
 
-        foreach ($part->parts as $subpart) {
-            $this->get_mime_numbers($subpart);
+        for ($i = 0; $i < count($part->parts); $i++) {
+            $this->get_mime_numbers($part->parts[$i]);
         }
     }