glfw.glfwGetVideoMode(monitor) failing

[DrLuke]

On python3, glfw.glfwGetVideoMode(monitor) will fail with the following error:

File "/home/drluke/prog/cockamamie/pyglfw/glfw.py", line 576, in glfwGetVideoMode
    return (c_mode.width,
AttributeError: 'LP_GLFWvidmode' object has no attribute 'width'

One working fix is to change the function from

def glfwGetVideoMode(monitor):
    _glfw.glfwGetVideoMode.restype = POINTER(GLFWvidmode)
    c_mode = _glfw.glfwGetVideoMode(monitor)
    return (c_mode.width,
            c_mode.height,
            c_mode.redBits,
            c_mode.blueBits,
            c_mode.greenBits,
            c_mode.refreshRate )

to

def glfwGetVideoMode(monitor):
    _glfw.glfwGetVideoMode.restype = POINTER(GLFWvidmode)
    c_mode = _glfw.glfwGetVideoMode(monitor)
    return (c_mode[0].width,
            c_mode[0].height,
            c_mode[0].redBits,
            c_mode[0].blueBits,
            c_mode[0].greenBits,
            c_mode[0].refreshRate )

I am not certain if this breaks functionality for python2 though, so I didn't yet submit a pullrequest.

[rougier]

Thanks. According to GLFW documentation, this function is supposed to return a pointer on a GLFWvidmode, thus I don't quite understand why the index is necessary. Do yo have any idea ?

[ercwyne]

The error is thrown because you need to access the contents of the pointer, not the pointer itself. Indexing does this for you for an array of pointers, but for one pointer:

c_mode.contents.height, ...

should be portable.

[rougier]

@ercwyne You mean the current version is ok, right ?

[ercwyne]

I'm running it on Python 3.6.1

The docs on pointer ctypes for 2.7 and 3 are identical, I think. Both mention the contents method and indexing. I think DrLuke's version and mine are functionally equivalent and should work on Python 2 and I can confirm that they are good on Python 3

Either way, they access the content of the pointer. Without an index or the contents method, the function only access the pointer, which raises the AttributeError