Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YARD error when parsing LiveScript lexer #1541

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

pyrmont
Copy link
Contributor

@pyrmont pyrmont commented Jun 9, 2020

A single line if-statement in the LiveScript lexer caused an error when YARD attempted to parse the code. Replacing it with a ternary statement fixed the problem. This is actually the code that is in the v3.20.0 gem.

@pyrmont pyrmont added the needs-review The PR needs to be reviewed label Jun 9, 2020
@pyrmont pyrmont self-assigned this Jun 9, 2020
@pyrmont pyrmont merged commit 29ad1ba into rouge-ruby:master Jun 19, 2020
@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Jun 19, 2020
@pyrmont pyrmont deleted the bugfix.livescript-yardoc-bug branch June 19, 2020 17:36
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 19, 2021
A single line if-statement in the LiveScript lexer causes an error when
YARD runs over the project. Replacing it with a ternary statement fixes
the problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant