Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenType Feature file lexer #1519

Merged
merged 7 commits into from
Jun 1, 2020
Merged

Update OpenType Feature file lexer #1519

merged 7 commits into from
Jun 1, 2020

Conversation

punchcutter
Copy link
Contributor

Updated the OpenType feature file lexer with new keywords, fixes to string matching and escaped sequences. Added some more examples to the samples file.

@pyrmont pyrmont self-assigned this May 30, 2020
@pyrmont pyrmont added the needs-review The PR needs to be reviewed label May 30, 2020
pyrmont
pyrmont suggested changes May 30, 2020
View reviewed changes
Copy link
Contributor

@pyrmont pyrmont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going through the lexer and fixing a bunch of misses. Have a few questions:

lib/rouge/lexers/opentype_feature_file.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/opentype_feature_file.rb Show resolved Hide resolved
lib/rouge/lexers/opentype_feature_file.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/opentype_feature_file.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/opentype_feature_file.rb Outdated Show resolved Hide resolved
lib/rouge/lexers/opentype_feature_file.rb Outdated Show resolved Hide resolved
@pyrmont pyrmont added author-action The PR has been reviewed but action by the author is needed maintainer-action The PR has been reviewed but action by a maintainer is required needs-review The PR needs to be reviewed and removed needs-review The PR needs to be reviewed author-action The PR has been reviewed but action by the author is needed maintainer-action The PR has been reviewed but action by a maintainer is required labels May 30, 2020
@pyrmont pyrmont merged commit 37ea838 into rouge-ruby:master Jun 1, 2020
@pyrmont
Copy link
Contributor

pyrmont commented Jun 1, 2020

@punchcutter Thanks for the PR! Merged it in :) This will be part of the next version of Rouge, v3.20.0. That will be pushed to RubyGems on Tuesday 9 June 🎉

@pyrmont pyrmont removed the needs-review The PR needs to be reviewed label Jun 1, 2020
@punchcutter
Copy link
Contributor Author

Awesome. Thank you!

@punchcutter punchcutter deleted the opentype_features branch June 1, 2020 21:13
mattt pushed a commit to NSHipster/rouge that referenced this pull request May 19, 2021
@punchcutter @mattt
Add new keywords to and fix bugs in OpenType feature file lexer (roug…
d5d38cd 
…e-ruby#1519)

This commit updates the OpenType feature file lexer with new keywords
and fixes to identifiers, include paths, strings and numbers. It also
adds additional examples to the visual sample.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrmont pyrmont pyrmont approved these changes

Assignees

@pyrmont pyrmont

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@punchcutter @pyrmont