Fix implementation of Lexer.detectable?
#1425
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the existing memoization implemented in
Lexer.detectable?
.Memoizing with
||=
is negated when the computed result equalsfalse
. Instead, check if the singleton instance variable is defined and if so, return its value. Otherwise, proceed to compute and store result in the instance variable.An additional change is replacing
methods(false)
withsingleton_methods(false)
. For a singleton class, the two calls are equivalent and using the latter expresses intent better.