Add block support to Lexer.find_fancy #1195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method `Lexer.lookup_fancy` returns a Lexer subclass while the method `Lexer.find_fancy` returns an instance of the Lexer subclass. This is not evident from the name and so this commit renames `lookup_fancy` to `find_fancy_class`. Separately, the commit also adds support to consumers passing a block to `find_fancy`. It is not envisaged that block passing will be common. Finally, test are added.
pyrmont
added
the
dependent-pr
pyrmont
force-pushed
the
feature.lexer-with
branch
from
3c54f92 to
451b978
Compare
|
@tancnle I'm afraid I don't remember any more :( Without having looked at the PRs in detail, I could imagine that there are still some ideas in this code that would make the API slightly more consistent but if this has been outstanding for the last three years, it's probably a safe bet that the changes weren't that important :D |
|
Thanks for the prompt respond, @pyrmont. I will close this PR then. Thank you for your work on this 🙇🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion is intended to continue in #1188.
Currently, revisions to
Lexerare being discussed in #1188. This PR is intended to improve the solution provided in that branch.The code proposed in #1188 includes a method
Lexer.lookup_fancythat returns a Lexer subclass. This is in addition to the existing methodLexer.find_fancythat returns an instance of a Lexer subclass. This difference is not evident from the names of the methods and so this commit renameslookup_fancytofind_fancy_class.Separately, the commit also adds support to consumers passing a block to
find_fancy. It is not envisaged that block passing will be common but supporting it allows for consumers to use idiomatic Ruby to customise the instantiation of a lexer.Finally, tests are added.