Add missing CoffeeScript keywords and reserved words #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing keywords: `until`, `loop`, `do`, `yield` (old ones), `debugger` (an obscure one inhereted from JavaScript), and `await`, `import`, `export` (added in CoffeeScript 2). Added missing reserved words based on RESERVED list in CoffeeScript source code. (Previously there were no reserved words.) See https://coffeescript.org/annotated-source/lexer.html#constants
|
@edemaine Thanks for submitting this! We've recently updated our Travis configuration. Would you be able to do a force push to kick off a new round of testing? You should be able to do something like: $ git commit --amend
$ git push --force |
pyrmont
added
the
author-action
|
@pyrmont Done! |
|
Thanks! |
pyrmont
removed
the
author-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing keywords:
until,loop,do,yield(old ones),debugger(an obscure one inhereted from JavaScript), andawait,import,export(added in CoffeeScript 2).Added missing reserved words based on
RESERVEDlist in CoffeeScript source code. (Previously there were no reserved words.)See https://coffeescript.org/annotated-source/lexer.html#constants
I also made
inandofinto operators, as they can be used in arbitrary context, not just inforloops, and also to be consistent withnot(currently an operator). Before this PR, thenot inoperator formats rather inconsistently:As a bonus, this last change fixes #1056.
Not addressed by this PR:
for ... fromdoesn't highlightfrom(which is not a keyword), andfor owndoesn't highlightown(also not a keyword). Should I add these to operators, or add more complex rules to capture the context where they actually matter? This PR or another PR? Actually, same forimport ... aswhichjavascript.rbseems to just call a keyword (which is not correct -- you can assignas = 5in JS and CS).