PDF: fix nullptr dereference on invalid file

Fixes https://issues.oss-fuzz.com/issues/376126833
rouault · Oct 29, 2024 · 2ed74d7 · 2ed74d7
1 parent b4a3fde
commit 2ed74d7
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/autotest/gdrivers/data/pdf/invalid_srs.pdf b/autotest/gdrivers/data/pdf/invalid_srs.pdf
diff --git a/autotest/gdrivers/pdf.py b/autotest/gdrivers/pdf.py
@@ -3345,3 +3345,14 @@ def test_pdf_iso32000_esri_as_epsg():
     assert sr.GetAuthorityName(None) == "ESRI"
     assert sr.GetAuthorityCode(None) == "102422"
     assert gdal.GetLastErrorMsg() == ""
+
+
+###############################################################################
+# Test bugfix for https://issues.oss-fuzz.com/issues/376126833
+
+
+@pytest.mark.skipif(not have_read_support(), reason="no read support available")
+def test_pdf_iso32000_invalid_srs():
+
+    # Just test that this does not crash
+    gdal.Open("data/pdf/invalid_srs.pdf")
diff --git a/frmts/pdf/pdfdataset.cpp b/frmts/pdf/pdfdataset.cpp
@@ -7074,8 +7074,9 @@ int PDFDataset::ParseMeasure(GDALPDFObject *poMeasure, double dfMediaBoxWidth,
                 // Check consistency of ESRI:xxxx and WKT definitions
                 if (poGCSWKT != nullptr)
                 {
-                    if (!EQUAL(oSRS_ESRI.GetName(), m_oSRS.GetName()) &&
-                        !oSRS_ESRI.IsSame(&m_oSRS))
+                    if (!m_oSRS.GetName() ||
+                        (!EQUAL(oSRS_ESRI.GetName(), m_oSRS.GetName()) &&
+                         !oSRS_ESRI.IsSame(&m_oSRS)))
                     {
                         CPLDebug("PDF",
                                  "Definition from ESRI:%d and WKT=%s do not "