VoyageAI text embedder #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-okuda
commented
Oct 13, 2025
pdeziel
reviewed
Oct 15, 2025
Contributor
pdeziel
left a comment
pdeziel
left a comment
There was a problem hiding this comment.
Looks good, I had a few suggestions to make this easier when it gets integrated into Endeavor for your review.
pdeziel
approved these changes
Oct 17, 2025
Contributor
pdeziel
left a comment
pdeziel
left a comment
There was a problem hiding this comment.
Looks good, I just have two more suggestions to finalize this.
…rom the library (only from the test), requiring the user to load the env vars when they need them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Add a VoyageAI text embedding client as a
Vectorizer.Fixes SC-35232
Type of change
Acceptance criteria
No special review needs, just the usual stuff.
Author checklist
Reviewer(s) checklist