Made role idempotent #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codecounselor
commented
Oct 30, 2016
| seconds: 3 |
There was a problem hiding this comment.
This was already here, but the one I removed from was set to 6 seconds. Not sure the reason for 3 vs. 6, should this be a property?
|
@rossmcdonald Any feedback on this? |
|
@codecounselor Sorry! I don't get notifications for PR's for some reason. I'll review this here in the next couple of hours, though. |
|
@codecounselor Great work. This has drastically improved rerun times and I like the use of the handlers. Thank you for the help! |
|
Thank you @rossmcdonald, happy to contribute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when: telegraf_start_serviceis only in main.yamlhandlers/main.yml alreadybut it wasn't used - I added notify events for anything that should not run unless a change event happens