Fixes #1328 #1465
Merged
Fixes #1328 #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulCavill
pushed a commit
to PaulCavill/localtuya
that referenced
this pull request
Sep 4, 2023
rospogrigio
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Issue: #1328
Restarting HomeAssistant without an external internet connection fails initialization when API is set in config. Tries to get access token and has an uncontrolled crash.
Note: The
elsein__init.pyis becausetuya_api.async_get_devices_list()also causes a crash without an internet connection.This also fixes if there's a non-ok response from the cloud. This might not be beneficial in all cases; Example: having invalid credentials, it might be better to have the crash so the user is aware of the issue. If that is desired I propose having a custom exception instead of waiting until
async_get_devices_listfails.