Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code changes and fix issue #1375 #1397

Closed
wants to merge 17 commits into from
Closed

Conversation

oven-lab
Copy link

@oven-lab oven-lab commented May 20, 2023

What has been done?

  1. Fixed issue Error handling request #1375 with PR Fix deprecated async_get_registry #1381 . Thereby Fix deprecated async_get_registry #1381 is obsolete.
  2. Added HACS validation as described here.
  3. Added Hassfest validation as described here.
  4. Fixed issues with the validations and also removed the old ha-blueprint validation that is being retired.
  5. Updated tox.ini to make checks pass.
  6. Added version tag 5.0.1 for the next release (aka. these changes,)

Why?

  • Be able to add and edit localtuya devices
  • Make contributing easier and more smooth.
  • Make sure that the repository meets all HACS and HA standards.

oven-lab added 12 commits May 20, 2023 10:05
…t_registry

Fix depreciated async_get_registry
Alphabetized manifest.json according to home assistant requirements.
As described in KTibow/ha-blueprint, ha-blueprint is being retired and we should thereby switch over to hassfest and hacs validation.
Added workflow_dispatch
@oven-lab oven-lab changed the title Code changes Code changes and fix issue #1375 May 20, 2023
@oven-lab oven-lab closed this May 22, 2023
@oven-lab
Copy link
Author

I see now that my commits for local testing is automatically added to my pull request. Hence i close this pr until i have fixed it.

So sorry! I'm not used to making pull requests...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant