Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for "Comfort Airflow" #29

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

droscy
Copy link
Contributor

@droscy droscy commented Nov 16, 2021

Hello, I've added support for "Comfort Airflow" in swing modes (if device support it) and I made some fixes.
Unfortunately that setting can only be shown or disabled, not enabled, the official app does the same (tapping on "Auto" for vertical fan has no effect).

The method getCloudDevices() executes getCloudDeviceDetails() as first
call, so there is no need to manually call getCloudDeviceDetails() on setup.
Two options are added to "Swing mode" in climate entities to handle
the "Comfort Airflow" option if the physical devices support it:

 - Auto Vertical: "Comfort Airflow" enabled and horizontal swing disabled
 - Auto 3D: "Comfort Airflow" and horizontal swing both enabled
@XilefTech
Copy link

XilefTech commented Jun 25, 2022

@rospogrigio will this ever be merged? my device supports comfort airflow and I would really like to use it from homeassistant!

@droscy
Copy link
Contributor Author

droscy commented Jun 26, 2022

@XilefTech in the mean time you can install my "master" branch, even if it is not official and you have to install it manually, you can have a try.

@rospogrigio
Copy link
Owner

@rospogrigio will this ever be merged? my device supports comfort airflow and I would really like to use it from homeassistant!

Before it can be merged, the conflicts shall be resolved, then I'd need some time to test it...

@XilefTech
Copy link

@droscy thx for the tip, I did that and it works great!

@rospogrigio so it will never happen? don't want to be rude but that "I'd need some time to test it..." sounds kinda like "will never happen because I got other stuff todo"

@rospogrigio
Copy link
Owner

No, I don't want to sound rude either but first let's solve the conflicts, then let me try this because Rule #0 for all my repositories is that they must not break MY configuration/appliance 🤣 , so I need to test it on my own environment. I do have some high and some low load periods so it just depends on how things are going (and holidays are coming in soon, too) but it's not a "never", although it's not an "immediately" either. When I deem a PR useful, I try to find a time slot to install it, test it 2-3 days and then release it when I'm sure enough it is ok.
This week is going to be really busy, maybe next one I could find some time but cannot assure you.
Bye

@droscy
Copy link
Contributor Author

droscy commented Jun 28, 2022

I can do the merge in my branch if that can help you...

@Jawadde1
Copy link

For me on a Perfera device with module BRP069C4x only "Auto Vertical" seemed to work.
On a Stylish device with module BRP069B4x the extra features didn't show but this unit has the most options.
Would love for this to be worked on further and eventually be integrated though, it's the best feature of these A/Cs.

@droscy
Copy link
Contributor Author

droscy commented Sep 19, 2022

Hello @Jawadde1, the "Auto 3D" means "Comfort Airflow" enabled and "Horizontal Swing" enabled. Do the Perfera device has the horizontal swing? What you see in the device when you set "Auto 3D"?

@jwillemsen
Copy link
Contributor

#105 is in the same area, adding more swing modes

@jwillemsen
Copy link
Contributor

https://github.com/jwillemsen/daikin_residential_altherma has now also integration for Daikin AC units, should be much easier to add this support to that integration.

@jwillemsen
Copy link
Contributor

Can you try https://github.com/jwillemsen/daikin_residential_altherma/releases/tag/v3.1.0, made some changes to support more swing modes today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants