Skip to content
This repository was archived by the owner on Aug 11, 2023. It is now read-only.

Fix problems shutting down nodes #296

Merged
merged 2 commits into from
Apr 5, 2019
Merged

Fix problems shutting down nodes #296

merged 2 commits into from
Apr 5, 2019

Conversation

@rjcausarano
Copy link
Contributor

@rjcausarano rjcausarano commented Apr 4, 2019

Fixes failing ServiceIntegrationTests (issue #267) and also issue #241.

jubeira
jubeira approved these changes Apr 5, 2019
View reviewed changes
Copy link

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rjcausarano, LGTM!

For the record, #242 fixed #241 but broke the tests described in #267.
This restores the tests in #267 while still addressing #241.

@jubeira jubeira merged commit 9a4116c into rosjava:kinetic Apr 5, 2019
@jubeira jubeira mentioned this pull request Apr 10, 2019
Closed
@rjcausarano rjcausarano deleted the test-fix-proposal branch April 10, 2019 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jubeira jubeira jubeira approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rjcausarano @jubeira @googlebot