This repository was archived by the owner on Aug 11, 2023. It is now read-only.
Avoid a race condition in RetryingExecutorService #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes rosjava#274, which occurs when the task completes before the `Future` is added to the `callables` map (because the corresponding submit() is still executing). In that case, `callable` is null, which causes latches.get(callable) to throw an NPE. The bug can be reproduced with the added test by adding `Thread.sleep(1000)` below the `completionService.submit` call.
|
If you prefer I can remove the test from this PR - it's pretty messy since it uses a real ScheduledThreadPoolExecutor and lots of timeouts. I looked into faking ScheduledExecutorService but it's not trivial. You can see the scale in google-cloud-java's FakeScheduledExecutorService (I haven't looked in to reusing that). |
jubeira
approved these changes
May 18, 2018
There was a problem hiding this comment.
The fix makes sense to me, and I think it's perfectly fine to add the test in the same PR.
@msmcconnell perhaps you will want to try this out :)
|
Thanks for the review! |
|
Nice job drigz! I had locally confirmed the same cause of the issue and a similar solution (didn't have time to update it here). Now I should be able to re-target back to the main kinetic branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #274, which occurs when the task completes before the
Futureis added to thecallablesmap (because the correspondingsubmit() is still executing). In that case,
callableis null, whichcauses latches.get(callable) to throw an NPE.
The bug can be reproduced with the added test by adding
Thread.sleep(1000)below thecompletionService.submitcall.