Skip to content
This repository was archived by the owner on Aug 11, 2023. It is now read-only.

Small change to NativeNodeMain #229

Merged
merged 1 commit into from
Jan 4, 2017

Conversation

jubeira
Copy link

@jubeira jubeira commented Jan 4, 2017

Shutdown and Execute abstract functions now return an error code (for further use in NativeNodeMain).
Error codes can currently be used extending NativeNodeMain.
Corrected nodeName assignment.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jubeira
Copy link
Author

jubeira commented Jan 4, 2017

This small change was discussed with NativeNodeMain author @ernestmc.

@googlebot
Copy link

CLAs look good, thanks!

@adamantivm
Copy link
Contributor

Thanks @jubeira !

@adamantivm adamantivm merged commit fe2b833 into rosjava:kinetic Jan 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants