This repository was archived by the owner on Jan 14, 2023. It is now read-only.
Using ChannelBuffer for int8[] types #72
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the changes in #65, messages with
int8[]
fields are converted tobyte[]
datatypes in Java messages, but all the message artifacts inrosjava_mvn_repo
and the code inandroid_core
and so on is still usingChannelBuffer
for these cases.Steps to reproduce: build
rosjava
ws from source, source the environment, and buildandroid_core
from scratch usingcatkin
.catkin
will use the generated message artifacts in the first step instead of using the artifacts inrosjava_mvn_repo
, and the build will break when trying to usegetData
from messages containingbyte[]
. Error copied below:I'm not saying that using
byte[]
is wrong, but it breaks the API for messages using this type of objects and therefore all the code using these messages.This PR reverts the changes in #65 and attempts to fix the test by using
ChannelBuffer
instead ofbyte[]
inRawMessage
interface. I'm not 100% sure whether we should supportbyte[]
in the set method.Comments on this are welcome.