Fix unofficial message dependency generation. #13
Conversation
ghost
assigned
|
The last commit moves to handling message artifact generation with a single api and is now able to properly detect message packages - it checks for build_depends on message_generation instead of the weak check for xxx_msgs/xxx_srvs naming convention which isn't strictly followed by many. |
|
Tacked on the android plugin upgrade requirement by android studio (just a one liner). |
|
And a very simple bugfix to remove some warnings and partially handle an esoteric use case: rosjava/rosjava_core#186. |
| @@ -159,6 +159,15 @@ public static void main(String[] args) { | |||
| arguments.add("."); | |||
| } | |||
| String rosPackagePath = System.getenv(ROS_PACKAGE_PATH); | |||
| // Overwrite with a supplied package path if specified (--package-path=) | |||
There was a problem hiding this comment.
I'm not sure I understand the motivation here. ROS_PACKAGE_PATH is required for all sort of things to work. In fact, the CatkinPlugin uses it in the constructor to find all workspaces. As far as I can tell, replacing it here is no-op.
Am I missing something?
There was a problem hiding this comment.
Comes from this commit: 0857890
This was to solve the following use case.
Often you will have a msg package deb installed and a source workspace running on top which is working on a development (bumped) version of the sources. In this case the java generation code is going to find two packages with the same name and it has no intelligent heuristic for choosing which package will be selected (I can't recall off the top of my head, but it ignores the ROS_PACKAGE_PATH sequence as well). This often results in generation of the deb message package, not the new sources. With the gradle plugin telling it where to look it can guarantee we get the new sources. It also provides a considerable speedup when calling the generator on a single package or a subset of a very large suite of packages.
This is pretty important for us - otherwise we have to uninstall debs to do development on unstable sources, and then install the debs to do development on release resources. Very impractical and annoying.
Adds more robust message package detection from PR #13
|
I actually made use of the --package-path flag myself the other day. It's a nice addition :) |
Cherry picked fixes from hydro to bugfix #12 and #14.